Recent
Categories
View Replies (4)

Menu Link Type URL - Attributes

  1. Issue
0
Votes
Undo
  1. dautrich
    dautrich
  2. Sherlock Holmes The Voice
  3. Commercial Templates
  4. Tuesday, 08 December 2020
  5.  Subscribe via email
Hi Ciaran,

I have menu items of type External URL in my site. Now I wanted to add the attribute 'rel="noreferrer"' to those menu items. To achieve that, I set the respective option in the link type parameter of the menu item (s. Menu_item_URL_rel-attribute_noopener.jpg). I saved the menu item, and everything seemed to be okay.

However, controlling the effect in the developer tools of my browser, I saw that the attribute was not set (s. Attribute_rel-noopener_not_in_code.jpg).

This might be a problem in Joomla core. But doing some research in Google, I saw that users of other templates had this issue as well. So I decided to address it to you.

Best regards,

Rolf


PS: See also the discussion on Github: [4.0] Serverside enforcement of rel=noopener for all external links #24337
Attachments (2)
Menu_item_URL_rel-attribute_noopener.jpg Menu_item_URL_rel-attribute_noopener.jpg
Attribute_rel-noopener_not_in_code.jpg Attribute_rel-noopener_not_in_code.jpg
Responses (4)
ciaran
ciaran
Love Fool Sherlock Holmes The Voice
Notable Answerer Notable Answerer
Accepted Answer Pending Moderation
0
Votes
Undo
Hi Rolf

Check if the following folder exists... ../templates/[YourTemplate/html/mod_menu. If yes try renaming this folder to mod_menu_bak and see if the issue persists?

Ciaran
  1. more than a month ago
  2. Commercial Templates
  3. # 1
dautrich
dautrich
Sherlock Holmes The Voice
Accepted Answer Pending Moderation
0
Votes
Undo
Hi Ciaran

after renaming mod_menu the rel-attribute rel="noopener noreferrer" was inserted.

Just being curious: What was your reason for overriding mod_men ?

Regards
Rolf
Attachments (1)
Attribute_rel-noopener_in_code.jpg Attribute_rel-noopener_in_code.jpg
  1. more than a month ago
  2. Commercial Templates
  3. # 2
ciaran
ciaran
Love Fool Sherlock Holmes The Voice
Notable Answerer Notable Answerer
Accepted Answer Pending Moderation
0
Votes
Undo
Hi Rolf

The primary reason was to allow the option to add modules to the menu dropdowns.

Thank you for reporting back. I will look into ensuring that the menu override includes the rel-attribute from the module settings.

Ciaran
  1. more than a month ago
  2. Commercial Templates
  3. # 3
dautrich
dautrich
Sherlock Holmes The Voice
Accepted Answer Pending Moderation
0
Votes
Undo
Hi Ciaran,

when you correct the rel-attribute in your menu override, you might also want to have a look at the social icons.

I have included the rel-attribute in /link/layouts/social_icons.php as well (s. Modifikation_Skylar_inc_layouts_social_icons_php.jpg). I've done it only for Facebook, because I don't need the other social networks.

Regards,
Rolf
Attachments (1)
Modifikation_Skylar_inc_layouts_social_icons_php.jpg Modifikation_Skylar_inc_layouts_social_icons_php.jpg
  1. more than a month ago
  2. Commercial Templates
  3. # 4
  • Page :
  • 1


There are no replies made for this post yet.
Be one of the first to reply to this post!