Recent
Categories
View Replies (2)

Error in fonts.php

  1. Bug
0
Votes
Undo
  1. chrishoefliger
    chrishoefliger
  2. Sherlock Holmes
  3. Commercial Templates
  4. Wednesday, 01 June 2022
  5.  Subscribe via email
It has been pointed out to me that there is an error in fonts.php line 38 where it says



foreach ($googlefonts as $v) { // loop

	$app->getDocument()->addStyleSheet('//http://fonts.googleapis.com/css?family=' . $v . ':' . $font_weights . '&&subset=' . $font_subset . '&display=swap');

}


It appears that Joomla converts & amp ; & to & amp ; & amp ; & and when it gets parsed as XML it gets converted back and therefore not replaced.

You can find the discussion here in this forum
https://forum.joomla.de/thread/16020-jt-aldef-1-0-8-macht-probleme/?postID=108744#post108744
Responses (2)
ciaran
ciaran
Love Fool Sherlock Holmes The Voice
Notable Answerer Notable Answerer
Accepted Answer Pending Moderation
0
Votes
Undo
Hi CHris

Thank you for bringing this to our attention. Could you detail for me the error this issue has caused? Eg. how has it affected your site?

Kind regards
Ciaran
  1. more than a month ago
  2. Commercial Templates
  3. # 1
chrishoefliger
chrishoefliger
Sherlock Holmes
Accepted Answer Pending Moderation
0
Votes
Undo
Hi Ciàran,
I have a plugin on my site that downloads the fonts selected in the template from google's site and makes them available locally. A new version of this plugin would not work at all and so I contacted the developer. He looked into a copy of my site and noted that the plugin would not work, because it would try to download a fon-wight that is not available for one of the fonts I use. He then pointed out, that there's an error in the code you provide. Even though finally the error was that the plugin stopped working because of the font-weight issue, he felt obliged to point out the error in your code.That's why I wrote up this as an issue.
kind regards
  1. more than a month ago
  2. Commercial Templates
  3. # 2
  • Page :
  • 1


There are no replies made for this post yet.
Be one of the first to reply to this post!