Reference in inc/scripts.php Carmen template

Votes

Undo

Oliver
Commercial Templates
Wednesday, 04 September 2019
Subscribe via email

Hello Ciaran,
I found a little bug in inc/scripts.php in Carmen template.
There is a "wrong" quotation mark in code line 72 after the file ending .js:



line72: $document->addScript('https://cdnjs.cloudflare.com/ajax/libs/waypoints/4.0.1/noframework.waypoints.min.js"', true, false);

BTW: can I change the external script to internal? Are there any disadvantages?
I thought of:



line72: $document->addScript('templates/'.$this->template.'/js/noframework.waypoints.min.js', true, false);

and adding the js file to the template/js directory.
What do you think?

Regards
Oliver

Responses (1)

ciaran

Accepted Answer Pending Moderation

Votes

Undo

Hi Oliver

My sincere apologies for the delay with your query. We somehow missed this one!

Thank you for bringing this issue to our attention. This will be fixed in the next update of the template.

Regarding loading the waypoint script locally, yes you are correct. Save the waypoint script locally (https://cdnjs.cloudflare.com/ajax/libs/waypoints/4.0.1/noframework.waypoints.min.js) and use the method you correctly described.

Ciaran

more than a month ago
Commercial Templates
# 1

Page :
1

There are no replies made for this post yet.
Be one of the first to reply to this post!

Please login to post a reply

You will need to be logged in to be able to post a reply. Login using the form on the right or register an account if you are new here. Register Here »

Forgot Password?

Reference in inc/scripts.php Carmen template

Site Links

Recommended

Join Our Newsletter