1. Oliver
  2. Sherlock Holmes The Voice
  3. Commercial Templates
  4. Wednesday, 04 September 2019
  5.  Subscribe via email
Hello Ciaran,
I found a little bug in inc/scripts.php in Carmen template.
There is a "wrong" quotation mark in code line 72 after the file ending .js:


line72: $document->addScript('https://cdnjs.cloudflare.com/ajax/libs/waypoints/4.0.1/noframework.waypoints.min.js"', true, false);


BTW: can I change the external script to internal? Are there any disadvantages?
I thought of:

line72: $document->addScript('templates/'.$this->template.'/js/noframework.waypoints.min.js', true, false);

and adding the js file to the template/js directory.
What do you think?

Regards
Oliver
Accepted Answer Pending Moderation
0
Votes
Undo
Hi Oliver

My sincere apologies for the delay with your query. We somehow missed this one!

Thank you for bringing this issue to our attention. This will be fixed in the next update of the template.

Regarding loading the waypoint script locally, yes you are correct. Save the waypoint script locally (https://cdnjs.cloudflare.com/ajax/libs/waypoints/4.0.1/noframework.waypoints.min.js) and use the method you correctly described.

Ciaran
  1. more than a month ago
  2. Commercial Templates
  3. # 1
  • Page :
  • 1


There are no replies made for this post yet.
Be one of the first to reply to this post!

Join Our Newsletter

* indicates required
We respect your privacy and do not tolerate spam and will never sell, rent, lease or give away your information (name, email, number, etc.) to any third party. Nor will we send you unsolicited email.
Joomla51 - Mullaghmore, Co. Sligo, Ireland
Joomla51.com is not affiliated with or endorsed by the Joomla! Project or Open Source Matters.
The Joomla! name and logo is used under a limited license granted by
Open Source Matters
the trademark holder in the United States and other countries.